right, it should be good now, would you guys mind giving it another shot? thanks a lot, alex
On Thu, Mar 20, 2014 at 2:17 PM, Alex Parvulescu <[email protected]>wrote: > ok found it, the check-release script removes the hidden files from the > *root* only > > > rm -f "$SVNDIR"/.??* # Remove hidden files not included in release > > I'm guessing this should be tweaked to include sub-folders too. > > > > > > On Thu, Mar 20, 2014 at 2:08 PM, Alex Parvulescu < > [email protected]> wrote: > >> ok it looks like a .gitignore file on the oak-run project fails the >> source comparison check. >> >> I'm not able to say why that is the case yet. >> There are 2 .gitignore files in the project, one on the root [0] and this >> new one on the oak-run project. >> The one on the root doesn't exist in the zip file either, but it doesn't >> fail the check, pretty weird so far. >> >> Also, is the .gitignore file so important? The error specifies it exists >> on the svn but not in the zip, which is not that bad in the end. >> >> I'll look into it more. >> >> best, >> alex >> >> >> [0] >> http://svn.apache.org/viewvc/jackrabbit/oak/tags/jackrabbit-oak-0.19/.gitignore?view=markup >> >> >> >> On Thu, Mar 20, 2014 at 1:13 PM, Julian Reschke <[email protected]>wrote: >> >>> On 2014-03-20 12:17, Davide Giannella wrote: >>> >>>> On 20/03/2014 11:06, Alex Parvulescu wrote: >>>> >>>>> $ sh check-release.sh oak 0.19 eb3e0c6aca065485b35e5ccad8f2cb >>>>> 5b95911209 >>>>> >>>>> Please vote on releasing this package as Apache Jackrabbit Oak 0.19. >>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>> least three +1 Jackrabbit PMC votes are cast. >>>>> >>>>> [ ] +1 Release this package as Apache Jackrabbit Oak 0.19 >>>>> [ ] -1 Do not release this package because... >>>>> >>>>> it gives me >>>> >>>> [INFO] 5. Compare svn tag with src zip contents >>>> [INFO] >>>> [INFO] Exporting >>>> https://svn.apache.org/repos/asf/jackrabbit/oak/tags/ >>>> jackrabbit-oak-0.19... >>>> [INFO] Unzipping jackrabbit-oak-0.19-src.zip... >>>> [INFO] Comparing sources... >>>> [INFO] >>>> Only in ./target/jackrabbit-oak-0.19/svn/jackrabbit-oak-0.19/oak-run: >>>> .gitignore >>>> [ERROR] NOT OK: Tagged sources are different from those in the archive >>>> >>>> maybe I'm doing something wrong. >>>> >>>> D. >>>> >>> >>> ...same here. >>> >>> >> >
