Hi, The proposed update sounds good, you should go for it. There is no need for a vote beforehand, a Jira issue with a patch attached works just fine.
best, alex On Tue, Aug 5, 2014 at 1:07 PM, Chetan Mehrotra <[email protected]> wrote: > +1 > > btw IMHO you need not go for a vote for incremental change in version > number of an existing library. Vote would be helpful when a new > library need to be introduced and that too in compile time > dependencies. For other case just opening a JIRA Task and making the > change against that task should be fine > Chetan Mehrotra > > > On Tue, Aug 5, 2014 at 3:40 PM, Davide Giannella <[email protected]> > wrote: > > Currently we use junit 4.10. By looking at the release notes of 4.11[0] > > there's a nice improvement on the Assume that we use, being able to > > provide a custom message. > > > > (0) > > > https://github.com/junit-team/junit/blob/master/doc/ReleaseNotes4.11.md#improvements-to-assert-and-assume > > > > I find it very useful cause some time tests are skip because of the > > failing assumption but we don't have any messages back and it's > > difficult to spot it. > > > > Let's vote for an upgrade and test. If passed I'll file an issue and > > follow up. > > > > [ ] +1 let's upgrade and test to junit 4.11 > > [ ] -1 no, I don't see any added value > > > > My vote: +1 > > > > Cheers > > Davide > > > > >
