On 23/09/2014 16:18, [email protected] wrote: > --- > jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java > (original) > +++ > jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/IndexUpdate.java > Tue Sep ... > @@ -170,7 +171,9 @@ public class IndexUpdate implements Edit > // as we don't know the index content node name > // beforehand, we'll remove all child nodes > for (String rm : definition.getChildNodeNames()) { > - definition.getChildNode(rm).remove(); > + if (NodeStateUtils.isHidden(rm)) { > + definition.getChildNode(rm).remove(); > + } > Don't have anything special against this commit but extending the concept of the ticket I'm asking myself: what if any future index logic stores any additional data under hidden nodes that doesn't need to be removed?
Let's say we want to keep logs of upgrades between the index definitions, I would store these kind of information under a hidden node as well. Is this something we would like to consider? Regards Davide
