Hi Chetan, I think no. 1 is definitely the best, also Solr doesn't support aggregation at the moment, so it'd be a good change to do that.
Regards, Tommaso 2014-10-08 11:17 GMT+02:00 Chetan Mehrotra <[email protected]>: > For OAK-2119 I had modified AggregateIndex to implement > AdvanceQueryIndex. This was done with the assumption that it is only > used by LuceneIndex. However Solr testcase do check against > AggregateIndex (though it is not configured for that at runtime) and > they fail with this change > > Now I have two options > > 1. Make SolrQueryIndex implement AdvanceQueryIndex and thus > AdvanceFulltextQueryIndex > 2. OR Duplicate AggregateIndex to have one impl for AdvanceQueryIndex > and other for QueryIndex > > Doing #1 should not take much effort but still a change in existing impl. > > Which route to take? > > Chetan Mehrotra >
