Hi,

Guys, thanks for the suggestions!

> May be better to exclude all under osgi-conf from license check
I did not want to extend the ignores more than they need to, so I would
leave them as is for now.

> Does the OSGi config allow comments?
Not sure, I haven't seen license headers in config files so far, but maybe
that's possible.

best,
alex



On Wed, Oct 15, 2014 at 10:40 AM, Marcel Reutegger <[email protected]>
wrote:

> Does the OSGi config allow comments? If it does, we could simply add
> the license header to those files...
>
> Regards
>  Marcel
>
> On 15/10/14 10:22, "Chetan Mehrotra" <[email protected]> wrote:
>
> >May be better to exclude all under osgi-conf from license check
> >
> ><exclude>osgi-conf/**/*.*</exclude>
> >Chetan Mehrotra
> >
> >
> >On Wed, Oct 15, 2014 at 1:39 PM,  <[email protected]> wrote:
> >> Author: alexparvulescu
> >> Date: Wed Oct 15 08:09:01 2014
> >> New Revision: 1631967
> >>
> >> URL: http://svn.apache.org/r1631967
> >> Log:
> >> OAK-2189 TarMK cold standby: update OSGi config example files
> >>  - fixed apache-rat excludes
> >>
> >> Modified:
> >>     jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
> >>
> >> Modified: jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml
> >> URL:
> >>http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-tarmk-failover/pom
> .
> >>xml?rev=1631967&r1=1631966&r2=1631967&view=diff
> >>
> >>=========================================================================
> >>=====
> >> --- jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml (original)
> >> +++ jackrabbit/oak/trunk/oak-tarmk-failover/pom.xml Wed Oct 15 08:09:01
> >>2014
> >> @@ -101,8 +101,9 @@
> >>                  <artifactId>apache-rat-plugin</artifactId>
> >>                  <configuration>
> >>                      <excludes>
> >> -
> >><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
> >>ver.store.FailoverStoreService.cfg</exclude>
> >> -
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
> >>er.store.FailoverStoreService.cfg</exclude>
> >> +
> >><exclude>osgi-conf/master/org.apache.jackrabbit.oak.plugins.segment.failo
> >>ver.store.FailoverStoreService.config</exclude>
> >> +
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.failov
> >>er.store.FailoverStoreService.config</exclude>
> >> +
> >><exclude>osgi-conf/slave/org.apache.jackrabbit.oak.plugins.segment.Segmen
> >>tNodeStoreService.config</exclude>
> >>                      </excludes>
> >>                  </configuration>
> >>              </plugin>
> >>
> >>
>
>

Reply via email to