I have marked OAK-2269 as Wont Fix. Would implement a minimal tree in oak-lucene to meet indexing requirements. Thanks for all the feedback! Chetan Mehrotra
On Fri, Nov 14, 2014 at 4:18 PM, Felix Meschberger <fmesc...@adobe.com> wrote: > Hi > >> Am 14.11.2014 um 11:22 schrieb Chetan Mehrotra <chetan.mehro...@gmail.com>: >> >> On Fri, Nov 14, 2014 at 3:29 PM, Felix Meschberger <fmesc...@adobe.com> >> wrote: >>> But all fields should (I’d even say must) be private and only be accessible >>> through getters. All non-private fields make it close to impossible to ever >>> refactor these fields. Add to it having the containing classes be exported >>> as API and you get implementation lock-in. >> >> Ack. Makes sense and as Michael mentioned that this class is not >> suitable to be exposed as part of API due such reasons only >> >>> An interface is something you implement to expose a behaviour. An interface >>> sporting constants is not defining behaviour. Therefore a „container“ for >>> constants should not be an interface. >> >> Ack. I knew that I would get negative marks from you for defending >> that when I sent that mail :) > > No negative marks at all ! Just to explain my train of thoughts :-) > > … and there are some things I am picky on :-) > > Regards > Felix
