On 2015-02-19 06:11, Chetan Mehrotra wrote:
Hi Tommaso,
On Wed, Feb 18, 2015 at 10:42 PM, <[email protected]> wrote:
+ } else {
+ if (log.isWarnEnabled()) {
+ log.warn("cannot create Solr query index as SolrServer {}Â is
unreachable", solrServer);
+ }
+ }
Minor suggestion - You can avoid doing a log check before doing actual
logging [1] if you use parameterized logging and parameters are direct
argument (i.e. not computed by some method call). That would reduce
the clutter in the code!
Chetan Mehrotra
[1]
http://stackoverflow.com/questions/8444266/even-with-slf4j-should-you-guard-your-logging
...and there seems to be a non-ASCII character in the commit...
