That can be done but some more details! When properties are read from framework properties then property names are prefixed with 'oak.documentstore.' kind of like namespaced as framework properties are flat and global. So if we need to do that for Segment also then we should use a similar namespaceing. For e.g. if the property name is 'cache' then when reading from fwk then 'oak.documentstore.cache' would be used
oak.mongo.uri and oak.mongo.db are spacial cased though and not follow this rule. Chetan Mehrotra On Tue, Jun 30, 2015 at 2:55 AM, Francesco Mari <[email protected]> wrote: > So we should probably adopt this strategy instead. This means that > SegmentNodeStoreService is the one that should be modified. > > 2015-06-29 17:15 GMT+02:00 Chetan Mehrotra <[email protected]>: >> Looking at code flow now yes it differs. The thought behind reading >> from framework property first was to provide a simple way to override >> the config which might be packaged by default. For e.g. while >> launching Oak via Sling one can provide the framework property at >> command line (using -Doak.mongo.uri) which would supercede the one >> packaged by default. This simplifies the testing. >> Chetan Mehrotra >> >> >> On Mon, Jun 29, 2015 at 7:01 PM, Davide Giannella <[email protected]> wrote: >>> On 29/06/2015 10:22, Francesco Mari wrote: >>>> ... >>>> >>>> Is it possible - or does it make sense - to make this behaviour >>>> uniform across components? >>>> >>> I think it's a good idea to uniform this aspect. Maybe we could put it >>> down as a guideline by setting up a new page on the doc site: >>> code-conventions.md. Somewhere beside: >>> http://jackrabbit.apache.org/oak/docs/dev_getting_started.html >>> >>> Personally I'd go for component first and bundle then, but I'm not too >>> religious about it :) >>> >>> Anyone against it? >>> >>> Davide >>> >>>
