Hi Tomek While I see that OAK-4128 has been resolved fixed, I still experience a failing SegmentToJdbcTest.validateMigration test, with my pending changes for OAK-4119.
I will take the liberty to mark the test with an @Ignore tag when committing my changes. What's your preferred way to investigate this? Shall I clone the OAK-4119? Or do you want to take a closer look once I am done such that you can actually experience the failure? Kind regards Angela On 16/03/16 14:26, "Angela Schreiber" <anch...@adobe.com> wrote: >Hi Tomek > >Thanks a lot for the confirmation and the issue! > >Just as a side node: our Adobe internal repositories >_always_ have a policy node at the root. If the sidegrade >is likely to be used in real, productive environments >this should IMO be considered a critical bug. > >Thanks and kind regards >Angela > > >On 16/03/16 14:00, "Tomek Rekawek" <reka...@adobe.com> wrote: > >>Hello Angela, >> >>> On 16 Mar 2016, at 12:39, Angela Schreiber <anch...@adobe.com> wrote: >>> >>> stepping into the AbstractOak2OakTest and finally >>> RepositorySidegrade.copyState i actually see that the target >>>NodeBuilder >>> that results from copyWorkspace doesn't have the jcr:mixinTypes >>> property copied from the src to the target, which consequently >> >>Indeed, it seems there's a bug, which causes the RepositorySidegrade to >>skip the root node properties. I think the reason lies in the >>calculateEffectiveIncludePaths() method, which produces an effective list >>of paths to migrate. If we have a '/' in the input list, the method will >>replace it with a list of '/' children and the root itself is removed >>from the list. >> >>Similar issue is present in the RepositoryUpgrade, but it isn't so >>dangerous there, as we create the root node anyway using an initializer. >> >>Created OAK-4128 to track this. >> >>However, the OAK-4128 is reproducible and present not only on the JDBC >>destination, so I guess the random failures (including the ones on >>Jenkins) are related to something else. >> >>Best regards, >>Tomek >> >>-- >>Tomek Rękawek | Adobe Research | www.adobe.com >>reka...@adobe.com >> >
