The warning raised for RemoteValue is actually a false alarm. It is legal to call asBoolean() only if isBoolean() is true. That said, I don't mind if the default implementation of asBoolean() returns null or false. Regarding RemoteValue, the patch attached to OAK-4257 looks good to me.
2016-04-20 16:49 GMT+02:00 Michael Dürig <[email protected]>: > > > On 20.4.16 3:54 , Alfusainey Jallow wrote: > >> Most NPEs issues (possible null pointer derefence) are also reported in >> many parts of the code base and most complains results in a call to >> NodeBuilder#getProperty(String). this method can return null and the >> return >> object should always be checked for null. however, most of its usage in >> the >> code base does not explicitly check for a null-return value. is this >> intentional too? >> > > Most of these are likely to be missing the null check. Some might really > never be null but and thus false positives. Sorting this out probably means > going through each of them manually. > > Michael >
