Couldn't we keep the map immutable and instead add some "WhateverCollector" instances as values? E.g. add a AffectedNodeTypeCollector right from the beginning?

Michael


On 3.8.16 4:06 , Chetan Mehrotra wrote:
So would it be ok to make the map within CommitInfo mutable ?
Chetan Mehrotra


On Wed, Aug 3, 2016 at 7:29 PM, Michael Dürig <[email protected]> wrote:


#A -Probably we can introduce a new type CommitAttributes which can be
attached to CommitInfo and which can be modified by the CommitHooks.
The CommitAttributes can then later be accessed by Observer


This is already present via the CommitInfo.info map. It is even used in a
similar way. See CommitInfo.getPath() and its usages. AFAIU the only part
where your cases would differ is that the information is assembled by some
commit hooks instead of being provided at the point the commit was
initiated.


Michael

Reply via email to