Thanks for putting this together. Finally I understand what this issue is about ;-) I left some comments there. Maybe a bit terse, but we can still flesh them out as required.
Michael On 31.8.16 5:12 , Stefan Egli wrote:
Hi, As an FYI: I'm working on persisting the observation queue - OAK-4581 - and have attached a patch and a comment [0] to the ticket indicating current progress. Would welcome some early feedback/review. The main idea is that it would introduce a 'PersistedBlockingQueue' that would be plugged (as the 'queue') into the BackgroundObserver, which can then remain largely unchanged. The whole logic of persisting is thus hidden in the PersistedBlockingQueue. PS1: The stored data would all be discarded on restart - this is just to work around the 'limit' aspect of the current in-memory queue at runtime. Nothing related to journaled observation. PS2: The current v0 implementation is a bit dumb, early progress - no tests, no generational-gc, not much batching/caching, but already uses a secondary (or is that thirdary?) SegmentNodeStore just for storing ContentChange objs. Thanks! Cheers, Stefan -- [0] https://issues.apache.org/jira/browse/OAK-4581?focusedCommentId=15452460&pag e=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-1 5452460
