Technically SegmentNodeStoreFactory is superset. If no role is defined it can register a NodeStore directly instead of registering it as NodeStoreProvider
Only downside with using factory way is that its tricky to override default OSGi config (something to be checked and confirmed) In general it would be good to have only factory mode ... just that we need to see if all required usage modes can be done with that or not Chetan Mehrotra On Tue, Dec 13, 2016 at 7:02 PM, Francesco Mari <[email protected]> wrote: > After reviewing and applying the patch for OAK-4978, I found myself > wondering if we need to make a distinction between > SegmentNodeStoreService and SegmentNodeStoreFactory. IIUC, the only > difference between the two seems to be the presence of a "role" > configuration property. The SegmentNodeStoreService seems to be a > special case of SegmentNodeStoreFactory where the "role" property is > unspecified. Should we remove SegmentNodeStoreService in favour of > SegmentNodeStoreFactory?
