Re: [Observation] Should listeners require constant inflow of commits to get all events?

[Vikas Saurabh]

> (patch which updates an existing test to show this at [0]. That patch
> would make ObservationQueueFullWarnTest#warnOnQueueFull fail.)
>
Attaching patch as inline one seemingly got malformed.

Thanks,
Vikas

diff --git 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationQueueFullWarnTest.java
 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationQueueFullWarnTest.java
index dda8eab..3fddac5 100644
--- 
a/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationQueueFullWarnTest.java
+++ 
b/oak-jcr/src/test/java/org/apache/jackrabbit/oak/jcr/observation/ObservationQueueFullWarnTest.java
@@ -115,6 +115,7 @@ public class ObservationQueueFullWarnTest extends 
AbstractRepositoryTest {
         try {
             customLogs.starting();
             addNodeToFillObsQueue();
+            emptyObsQueue();
             assertTrue("Observation queue full warning must get logged", 
customLogs.getLogs().size() > 0);
             customLogs.finished();
         } finally {
@@ -196,7 +197,7 @@ public class ObservationQueueFullWarnTest extends 
AbstractRepositoryTest {
             throws RepositoryException {
         blockObservation.acquireUninterruptibly();
         try {
-            for (int i = 0; i <= OBS_QUEUE_LENGTH; i++) {
+            for (int i = 0; i <= OBS_QUEUE_LENGTH+1; i++) {
                 addANode("n");
             }
         } finally {
@@ -222,6 +223,7 @@ public class ObservationQueueFullWarnTest extends 
AbstractRepositoryTest {
             //up in case last few event were dropped due to full observation 
queue
             //(which is ok as the next event that comes in gets diff-ed with 
last
             //processed revision)
+            /*
             if (numAddedNodes.get() < numObservedNodes.get() + 
OBS_QUEUE_LENGTH) {
                 try {
                     addANode("addedWhileWaiting");
@@ -229,6 +231,7 @@ public class ObservationQueueFullWarnTest extends 
AbstractRepositoryTest {
                     LOG.warn("exception while adding during wait: {}", e);
                 }
             }
+            */
             Thread.sleep(OBS_TIMEOUT_PER_ITEM/10);//The constant is exaggerated
             remaining = end - System.currentTimeMillis();
         }