The test will fail, but the cleanup after the failed test might run only partially. I had many cleanup issues myself for the segment store (e.g. files kept open, unclosed connections), and I found that code similar to this was the main offender. It was just a gentle warning, it might be that this problem is irrelevant to the document store!
2017-03-01 13:26 GMT+01:00 Marcel Reutegger <[email protected]>: > On 01/03/17 09:55, Francesco Mari wrote: >> >> I don't know the implementation of store.dispose() but if that call >> throws an exception fixture.dispose() will not be invoked. If there is >> no ordering dependency between store.dispose(), fixture.dispose(), and >> Revision.resetClockToDefault(), it's more robust to put them in >> different @After methods. > > > The ordering is important because there are dependencies between the calls. > store.dispose() may indeed fail with an exception, but that would fail the > test anyway, right? So, not sure if it is worth fixing all those tests. It's > not just the three tests that I updated. There are many more that would be > affected. > > Regards > Marcel
