Hi, Exposing the metrics registry is about exposing the data, while exposing the reporter would be exposing behavior. Doing so, the encouraged pattern here is that you get to tap into the metrics and pick whatever you like.
I thought that oak-core is the best position to say what metrics are needed, and the way that we want to extend the behavior is by picking whatever reporter we say fits the environment - this is why I started the thread, I wanted to understand whats the intended design. I was not saying that reporting in JMX is a good thing, I was simply stating that it can be the default in order not to break already existing assumptions. Why are the bellow mentioned reporters not in oak? Thanks, Andrei > On May 29, 2017, at 2:56 PM, Ian Boston <[email protected]> wrote: > > Hi, > Here are some reporters that work with Sling/Oak/AEM. [1]. They all look > for components registered as implementing MetricsRegistry and then > aggregate the data pumping it out to a reporter. They are all implemented > as independent bundles. <imvho>TBH I would avoid pumping the metrics into > JMX as JMX was designed for management, and not metrics. It might be able > to cope with trivial metrics sets, but will likely start to consume > unreasonable JVM resources with a production set of metrics.</imvho>. > > Most of the reporters in [1] are simple wrappers round other 3rd party > Metrics reporters. If you have a target not included in that list, its > trivial to follow the same pattern. > > HTH > Best Regards > Ian > > 1 > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fieb%2Fstatsd-reporter-osgi&data=02%7C01%7C%7Cf54c602fdb634fb1adad08d4a689d350%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636316558271983739&sdata=1ypTPtDZV8lxw95HEYrd2llBjlu%2F4KO1e3xISA8Hd2Y%3D&reserved=0 > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fieb%2Fprometheus-reporter-osgi&data=02%7C01%7C%7Cf54c602fdb634fb1adad08d4a689d350%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636316558271983739&sdata=so6%2F2Jn6m7zst5vZ3aCI25HOpOhPbk8RvomBPa7J%2B%2FA%3D&reserved=0 > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fieb%2Finfluxdb-reporter-osgi&data=02%7C01%7C%7Cf54c602fdb634fb1adad08d4a689d350%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636316558271993752&sdata=qyBUqTAxLSkFUPJZGIUujBqFVOnCy5I9n4su12i%2BWSo%3D&reserved=0 > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fieb%2Fgmond-osgi&data=02%7C01%7C%7Cf54c602fdb634fb1adad08d4a689d350%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636316558271993752&sdata=Wtvr1gs1nFRm5W81fGsA3l8QXUS6Cm8Z%2BMKE6%2F%2BEy2k%3D&reserved=0 > https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fieb%2Ftsdb-reporter-osgi&data=02%7C01%7C%7Cf54c602fdb634fb1adad08d4a689d350%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636316558271993752&sdata=V%2F%2BVdEsjyqiae1k%2BWSYGIecDt4v7loujSWdj8uue3jo%3D&reserved=0 > > On 29 May 2017 at 12:48, Andrei Kalfas <[email protected]> wrote: > >> Hi, >> >>> By default this is the only mode. >> >> What would you guys rather prefer, have a different component peeks into >> the metrics registry or change oak-core to deal with multiple reporters - >> Jmx should be the default one. >> >> Thanks, >> Andrei >> >>
smime.p7s
Description: S/MIME cryptographic signature
