Hi Chetan, org.slf4j.* ended up as optional, because that's how it was needed by some netty bundle. I didn't check to see any other use cases in Oak, but I will take your word for it :)
Regards, Andrei 2017-08-21 12:19 GMT+03:00 Chetan Mehrotra <[email protected]>: > > + org.slf4j.*;resolution:=optional, > > This should probably not be optional as its used by code > Chetan Mehrotra > > > On Mon, Aug 21, 2017 at 2:09 AM, <[email protected]> wrote: > > Author: adulceanu > > Date: Mon Aug 21 09:09:05 2017 > > New Revision: 1805608 > > > > URL: http://svn.apache.org/viewvc?rev=1805608&view=rev > > Log: > > OAK-6567 - Fix OSGi wiring after netty update to 4.1.x > > Added missing packages to import-package section from oak-segment-tar pom > > > > Modified: > > jackrabbit/oak/trunk/oak-segment-tar/pom.xml > > > > Modified: jackrabbit/oak/trunk/oak-segment-tar/pom.xml > > URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak- > segment-tar/pom.xml?rev=1805608&r1=1805607&r2=1805608&view=diff > > ============================================================ > ================== > > --- jackrabbit/oak/trunk/oak-segment-tar/pom.xml (original) > > +++ jackrabbit/oak/trunk/oak-segment-tar/pom.xml Mon Aug 21 09:09:05 > 2017 > > @@ -50,9 +50,16 @@ > > <Import-Package> > > com.google.protobuf.*;resolution:=optional, > > com.jcraft.jzlib.*;resolution:=optional, > > + com.ning.compress.*;resolution:=optional, > > + io.netty.internal.tcnative.*; > resolution:=optional, > > + io.netty.resolver.*;resolution:=optional, > > + javax.security.cert.*;resolution:=optional, > > javassist.*;resolution:=optional, > > + lzma.sdk.*;resolution:=optional, > > + net.jpountz.*;resolution:=optional, > > org.apache.tomcat.*;resolution:=optional, > > org.bouncycastle.*;resolution:=optional, > > + org.conscrypt.*;resolution:=optional, > > org.eclipse.jetty.alpn.*; > resolution:=optional, > > org.eclipse.jetty.npn.*; > resolution:=optional, > > org.jboss.marshalling.*; > resolution:=optional, > > @@ -60,8 +67,10 @@ > > sun.nio.ch.*;resolution:=optional, > > sun.security.util.*;resolution:=optional, > > sun.security.x509.*;resolution:=optional, > > + org.apache.commons.logging; > resolution:=optional, > > org.apache.logging.log4j.*; > resolution:=optional, > > org.apache.log4j.*;resolution:=optional, > > + org.slf4j.*;resolution:=optional, > > com.codahale.metrics*;version="[3.1, 4)", > > * > > </Import-Package> > > > > >
