kwin commented on code in PR #1523:
URL: https://github.com/apache/jackrabbit-oak/pull/1523#discussion_r1638409418
##########
oak-parent/pom.xml:
##########
@@ -71,12 +71,15 @@
<jackson.version>2.16.2</jackson.version>
<testcontainers.version>1.19.0</testcontainers.version>
<groovy.version>2.5.23</groovy.version>
- <java.version>1.8</java.version>
- <java.version.signature>java18</java.version.signature>
-
- <!-- specifies on which fixture to run the integration testing tests.
- override in profiles or provide from command line to change behaviour.
Provide
- more fixtures space separated. See
org.apache.jackrabbit.oak.jcr.FixturesHelper#AVAILABLE_FIXTURES
+ <!-- determines the bytecode version (i.e. the minimum JRE required to run
the build artifact) -->
+ <javaTargetVersion>8</javaTargetVersion>
+ <maven.compiler.release>${javaTargetVersion}</maven.compiler.release>
+ <maven.compiler.target>${javaTargetVersion}</maven.compiler.target>
+ <minimalJavaBuildVersion>${javaTargetVersion}</minimalJavaBuildVersion>
Review Comment:
> Detected JDK Version: 1.8.0-341 is not in the allowed range 8.
would be a very confusing error, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
