stefan-egli commented on code in PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#discussion_r1642692392


##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java:
##########
@@ -328,6 +332,7 @@ private void checkUniquenessConstraints() throws 
CommitFailedException {
                     String msg = String.format(
                             "Uniqueness constraint violated property %s having 
value %s",
                             propertyNames, failed);
+                    log.warn(msg);

Review Comment:
   I'm wondering if we should add a prefix to the log. Without the prefix it 
might be hard for down-stream logging to distinguish between the two sources of 
this message (the log.warn and the exception), as they contain a large common 
part. What about something like below (or maybe a better variant of it) ?
   ```suggestion
                       log.warn("checkUniquenessConstraints: " + msg);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to