jsedding commented on code in PR #1489:
URL: https://github.com/apache/jackrabbit-oak/pull/1489#discussion_r1686493310
##########
oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/CrossMountReferenceValidatorProvider.java:
##########
@@ -80,4 +82,18 @@ CrossMountReferenceValidatorProvider
withFailOnDetection(boolean failOnDetection
this.failOnDetection = failOnDetection;
return this;
}
+
+ @SuppressWarnings("unused")
+ @Reference(name = "mountInfoProvider", service = MountInfoProvider.class)
Review Comment:
You _could_ remove the explicit `service = MountInfoProvider.class`, as it
is inferred from the method signature.
##########
oak-store-composite/src/main/java/org/apache/jackrabbit/oak/composite/CompositeNodeStoreService.java:
##########
@@ -260,6 +265,7 @@ private void unregisterCompositeNodeStore() throws
IOException {
}
@SuppressWarnings("unused")
+ @Reference(name = "nodeStores", cardinality =
ReferenceCardinality.AT_LEAST_ONE, policy = ReferencePolicy.DYNAMIC, service =
NodeStoreProvider.class,
target="(!(service.pid=org.apache.jackrabbit.oak.composite.CompositeNodeStore))")
Review Comment:
Can we split this into multiple lines, like for `bindMountInfoProvider`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
