nfsantos commented on PR #1604: URL: https://github.com/apache/jackrabbit-oak/pull/1604#issuecomment-2252130874
> > Be careful when replacing `ImmutableList.of()`- in Guava, it preservers iteration ordering... > > In the JDK, `List.of` and `List.copyOf` also preserve the order by which the elements are added. The problem might be in replacing a Guava by an JDK Set. In Guava, the iteration order is deterministic, but in the JDK the iteration order changes each time the JVM is restarted (they use some kind of randomness to ensure that users do not rely on a fixed iteration order in sets). > > Tomorrow I will look more carefully at the usages of the sets in this class to make sure no code is depending on the iteration order of sets, which anyway would be a bug. I looked at all the cases of usages of Map or Set, and i did not find any that seemed to be relying on the order of iterations being always the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
