nfsantos commented on PR #1616: URL: https://github.com/apache/jackrabbit-oak/pull/1616#issuecomment-2264825838
> > It could still happen if those 1024 Strings are huge > > It would make sense to protect against that case, by limiting the string length we admit. (It is very unlikely that paths elements are longer, but then we have seen some weird edge cases... and the additional check is fast.) > > But other than that, I'm OK with the current patch. I added a check on the size of the strings, just to be extra safe. It's unlikely that there will ever be a very large path segment considered for interning because the condition is only considering the segments at the top 3 levels. These levels are very visible to application developers, so it's less likely that there would be a unreasonably large segment. But the extra check is indeed cheap, so no harm done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
