rishabhdaim commented on code in PR #1639:
URL: https://github.com/apache/jackrabbit-oak/pull/1639#discussion_r1715125393
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1263,6 +1275,11 @@ private void combineInternalPropRemovals(final
NodeDocument doc, final UpdateOp
private boolean isDeletedOrOrphanedNode(final NodeState
traversedState, final Path greatestExistingAncestorOrSelf,
final GCPhases phases, final
NodeDocument doc) {
+ if (fullGcMode == EMPTYPROPS) {
+ // we won't collect orphan nodes in this mode, only empty
properties would be collected.
+ return false;
+ }
+
Review Comment:
Sorry, missed to remove this.
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollector.java:
##########
@@ -1263,6 +1275,11 @@ private void combineInternalPropRemovals(final
NodeDocument doc, final UpdateOp
private boolean isDeletedOrOrphanedNode(final NodeState
traversedState, final Path greatestExistingAncestorOrSelf,
final GCPhases phases, final
NodeDocument doc) {
+ if (fullGcMode == EMPTYPROPS) {
+ // we won't collect orphan nodes in this mode, only empty
properties would be collected.
+ return false;
+ }
+
Review Comment:
Sorry, missed removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
