stefan-egli commented on code in PR #1665:
URL: https://github.com/apache/jackrabbit-oak/pull/1665#discussion_r1732594476
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStore.java:
##########
@@ -3405,9 +3405,18 @@ private String diffImpl(AbstractDocumentNodeState from,
AbstractDocumentNodeStat
fromRev = from.getRootRevision();
toRev = to.getRootRevision();
} catch (RuntimeException e) {
- LOG.warn("diffJournalChildren failed with " +
- e.getClass().getSimpleName() +
- ", falling back to classic diff", e);
+ // avoid filling the log file with stack traces for a known
issue
+ // see OAK-6016 and OAK-6011
+ if (e instanceof IllegalStateException &&
+ "Root document does not have a lastRev entry for local
clusterId 0".equals(e.getMessage())) {
+ LOG.warn("diffJournalChildren failed with " +
+ e.getClass().getSimpleName() +
+ ", falling back to classic diff");
Review Comment:
```suggestion
", falling back to classic diff : " +
e.getMessage());
```
minor comment : could consider re-adding the message as that would be
slightly more explicit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
