thomasmueller commented on code in PR #1669:
URL: https://github.com/apache/jackrabbit-oak/pull/1669#discussion_r1740665524
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/AheadOfTimeBlobDownloadingFlatFileStore.java:
##########
@@ -75,17 +80,35 @@ private
AheadOfTimeBlobDownloadingFlatFileStore(FlatFileStore ffs, CompositeInde
maxPrefetchWindowSize,
maxPrefetchWindowMB);
}
- }
+ }
+
+ static boolean isEnabledForIndexes(String indexesEnabledPrefix,
List<String> indexPaths) {
+ List<String> enableForIndexes = splitAndTrim(indexesEnabledPrefix);
+ for (String indexPath : indexPaths) {
+ if (enableForIndexes.stream().anyMatch(indexPath::startsWith)) {
+ return true;
Review Comment:
... in which case we have "/oak:index/...".startsWith("")... that would
always be true.
I think if enableForIndexes is empty, then this methods should always return
false.
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/AheadOfTimeBlobDownloadingFlatFileStore.java:
##########
@@ -75,17 +80,35 @@ private
AheadOfTimeBlobDownloadingFlatFileStore(FlatFileStore ffs, CompositeInde
maxPrefetchWindowSize,
maxPrefetchWindowMB);
}
- }
+ }
+
+ static boolean isEnabledForIndexes(String indexesEnabledPrefix,
List<String> indexPaths) {
Review Comment:
Assuming indexesEnabledPrefix is not set, we have an empty string here...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
