nfsantos commented on code in PR #1691:
URL: https://github.com/apache/jackrabbit-oak/pull/1691#discussion_r1746758955
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/PipelinedMongoDownloadTask.java:
##########
@@ -682,8 +677,15 @@ private void download(Bson mongoQueryFilter) throws
InterruptedException, Timeou
downloadRange(nextRange, mongoQueryFilter,
downloadOrder);
}
downloadCompleted = true;
+ } catch (IllegalStateException | InterruptedException |
MongoInterruptedException e) {
+ if (cancelled) {
Review Comment:
Here we have handled the interrupt by stopping the task, so I don't think we
need to propagate the interrupt. Can you think of any case where it may be
necessary to propagate? The task will terminate after the return below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
