JeonDaehong opened a new pull request, #1702:
URL: https://github.com/apache/jackrabbit-oak/pull/1702

   ### Description
   This PR addresses an issue where `MAX_SEGMENT_SIZE` was defined in both 
`Segment` and `SegmentDataUtils` with the same value, leading to redundancy. To 
resolve this:
   
   - `MAX_SEGMENT_SIZE` in `Segment.java` has been made `public`.
   - In `SegmentDataUtils.java`, the static import `import static 
org.apache.jackrabbit.oak.segment.Segment.MAX_SEGMENT_SIZE;` was added to 
utilize the constant defined in `Segment.java`.
   - The redundant definition of `MAX_SEGMENT_SIZE` in `SegmentDataUtils` has 
been removed.
   
   ### Motivation
   Having the constant defined in two places created potential maintenance 
issues and inconsistency risks. By consolidating the definition in 
`Segment.java`, the code becomes cleaner, more maintainable, and reduces the 
possibility of errors in future updates.
   
   ### Impact
   - No functionality change, purely a refactor.
   - This change should not impact existing functionality but reduces code 
duplication.
   
   Please review and merge this PR to streamline the constant usage in both 
classes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to