ionutzpi commented on code in PR #1711:
URL: https://github.com/apache/jackrabbit-oak/pull/1711#discussion_r1758264243


##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/VersionGarbageCollectorIT.java:
##########
@@ -2649,7 +2647,6 @@ public void 
testDeletedPropsAndUnmergedBCWithCollisionWithDryRunMode() throws Ex
         RevisionVector br3 = unmergedBranchCommit(store1, b -> 
b.child("foo").setProperty("a", "d"));
         RevisionVector br4 = unmergedBranchCommit(store1, b -> 
b.child("bar").setProperty("x", "z"));
         mergedBranchCommit(store1, b -> b.child("foo").removeProperty("p"));
-        store1.runBackgroundOperations();

Review Comment:
   Yes, indeed, commenting out that line will one hide the underlying issue. We 
have a subtle race condition in fullGC  
FullGCMode.ORPHANS_EMPTYPROPS_KEEP_ONE_ALL_PROPS(it appears randomly), we will 
fix the issue and let this test as it is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to