nfsantos commented on code in PR #1716:
URL: https://github.com/apache/jackrabbit-oak/pull/1716#discussion_r1760850735
##########
oak-run-commons/src/main/java/org/apache/jackrabbit/oak/index/indexer/document/flatfile/pipelined/ConfigHelper.java:
##########
@@ -48,4 +53,18 @@ public static boolean getSystemPropertyAsBoolean(String
name, boolean defaultVal
LOG.info("Config {}={}", name, value);
return value;
}
+
+ /**
+ * white space at the start/end of the string or at the start/end of the
parts delimited by separator are trimmed
+ */
+ public static List<String> getSystemPropertyAsStringList(String name,
String defaultValue, char separator) {
+ String result = System.getProperty(name, defaultValue);
+ List<String> parts = splitString(result, separator);
+ LOG.info("Config {}={}", name, parts);
+ return parts;
+ }
+
+ private static List<String> splitString(String str, char separator) {
Review Comment:
There are unit tests of `getSystemPropertyAsStringList`, which should be
enough to cover this method as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
