nfsantos commented on code in PR #1720: URL: https://github.com/apache/jackrabbit-oak/pull/1720#discussion_r1760980449
########## oak-doc/src/site/markdown/query/lucene.md: ########## @@ -483,14 +487,23 @@ type type is not used consistently across various nodes then it would recommended to specify the type explicitly. A binary is only indexed if there is an associated property `jcr:mimeType`. + For binary properties, you do not need to index the property separately. + Binary properties are automatically added to the fulltext index (but only there), + if the node is part of the index, if the node type (or mixin) matches, + if the mime type property is set, and if the mime type is indexed + (see the Tika configuration). propertyIndex : Whether the index for this property is used for equality conditions, ordering, - and is not null conditions. + and is not null conditions. Example query: Review Comment: Took me a while to understand what is meant by: `and is not null conditions.` I guess it should be read as "and `is-not-null` conditions", right? ########## oak-doc/src/site/markdown/query/lucene.md: ########## @@ -483,14 +487,23 @@ type type is not used consistently across various nodes then it would recommended to specify the type explicitly. A binary is only indexed if there is an associated property `jcr:mimeType`. + For binary properties, you do not need to index the property separately. + Binary properties are automatically added to the fulltext index (but only there), + if the node is part of the index, if the node type (or mixin) matches, + if the mime type property is set, and if the mime type is indexed + (see the Tika configuration). propertyIndex : Whether the index for this property is used for equality conditions, ordering, - and is not null conditions. + and is not null conditions. Example query: + * `/jcr:root/content//element(*, app:Asset)[@status = 'test']` + + Binary properties can not be queried in this way; they can only be queried + using the fulltext condition on the node, e.g. `jcr:contains(., 'image')`. notNullCheckEnabled : Since 1.1.8 -: If the property is checked for _is not null_ then this should be set to true. +: If the property is checked for `is not null` then this should be set to true. Review Comment: That's more clear, using quotes for `is not null`. ########## oak-doc/src/site/markdown/query/lucene.md: ########## @@ -483,14 +487,23 @@ type type is not used consistently across various nodes then it would recommended to specify the type explicitly. A binary is only indexed if there is an associated property `jcr:mimeType`. + For binary properties, you do not need to index the property separately. + Binary properties are automatically added to the fulltext index (but only there), + if the node is part of the index, if the node type (or mixin) matches, + if the mime type property is set, and if the mime type is indexed + (see the Tika configuration). Review Comment: This would be more clear as a bullet list. Do all of the conditions have to apply for a binary property to be indexed? My understanding is that yes. So it would more clear to say this explicitly, like: `if all of the conditions below are true:` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
