fabriziofortino commented on code in PR #1727:
URL: https://github.com/apache/jackrabbit-oak/pull/1727#discussion_r1766750949
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MissingLastRevSeekerTest.java:
##########
@@ -248,6 +248,7 @@ public void dispose() {
dns.merge(b1, EmptyHook.INSTANCE, CommitInfo.EMPTY);
}
dns.runBackgroundOperations();
+ Thread.sleep(1001);
Review Comment:
This might still fail when running on nodes with low resources or add
unneeded delays when the background operation completes quickly. In oak-search,
we make extensive use of the following utility method that takes care of both
issues:
https://github.com/apache/jackrabbit-oak/blob/3e315733e3932b77de9606271165190c2b106fa8/oak-search/src/test/java/org/apache/jackrabbit/oak/plugins/index/TestUtil.java#L247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
