reschke commented on code in PR #1745:
URL: https://github.com/apache/jackrabbit-oak/pull/1745#discussion_r1778192198
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/CompressedDocumentPropertyStateTest.java:
##########
@@ -238,6 +238,11 @@ private void
getBrokenSurrogateAndInitializeDifferentStores(DocumentStoreFixture
if (nodeStore != null) {
nodeStore.dispose();
}
+ try {
Review Comment:
In theory, disposing the node store should take care of this. We should find
out why it doesn't.
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/MissingLastRevSeekerTest.java:
##########
@@ -249,7 +251,7 @@ public void dispose() {
}
dns.runBackgroundOperations();
//seeker should return only non split documents
- int docs = Iterables.size(seeker.getCandidates(0));
+ int docs =
Iterables.size(seeker.getCandidates(Objects.requireNonNull(dns.getRoot().getLastRevision().getRevision(dns.getClusterId())).getTimestamp()));
Review Comment:
Is this related to the flakyness?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
