anchela commented on PR #1476: URL: https://github.com/apache/jackrabbit-oak/pull/1476#issuecomment-2404316623
also: i don't agree with some of the coding style decisions that have been made in the PR. so, this is a -1 from my side. we need to have a discussion what coding style we would want to enforce first and how strictly we want to enforce it. just spotted one example where the params are split to 2 lines instead of 1 in code that i worked on. i usually make a conscious decision to keep it on 1 line if it's not very long as i find it more readable. this is just one example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
