anchela commented on code in PR #1752:
URL: https://github.com/apache/jackrabbit-oak/pull/1752#discussion_r1794896795
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/principal/ExternalGroupPrincipalProvider.java:
##########
@@ -101,6 +102,7 @@
class ExternalGroupPrincipalProvider implements PrincipalProvider,
ExternalIdentityConstants, DynamicMembershipProvider {
private static final Logger log =
LoggerFactory.getLogger(ExternalGroupPrincipalProvider.class);
+ static final String CACHE_PRINCIPAL_NAMES = "externalPrincipalNames";
Review Comment:
`rep:externalPrincipalNames` is already taken (used) for the real external
principal names, right? so, i would avoid re-using the same name for the
caching prop.... specially since it is not totally accurate. the cache will
also contain local group names, which external groups are member of, no?
let's think about another name and add rep prefix. this is important to mark
it as oak-internal property.
e.g.
- rep:groupPrincipalNamesForExternal
- rep:groupPrincipalNamesExternal
- ....
wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
