ionutzpi commented on code in PR #1759:
URL: https://github.com/apache/jackrabbit-oak/pull/1759#discussion_r1795231050
##########
oak-store-document/src/test/java/org/apache/jackrabbit/oak/plugins/document/BranchCommitGCTest.java:
##########
@@ -82,6 +85,19 @@ public static java.util.Collection<Object[]> params() throws
IOException {
for (Object[] fixture : AbstractDocumentStoreTest.fixtures()) {
DocumentStoreFixture f = (DocumentStoreFixture)fixture[0];
for (FullGCMode gcType : FullGCMode.values()) {
+ if (gcType ==
FullGCMode.ORPHANS_EMPTYPROPS_BETWEEN_CHECKPOINTS_NO_UNMERGED_BC
+ || gcType ==
FullGCMode.ORPHANS_EMPTYPROPS_BETWEEN_CHECKPOINTS_WITH_UNMERGED_BC) {
+ // temporarily skip due to flakyness
+ continue;
+ }
+ if (f.getName().equals("Memory") ||
f.getName().startsWith("RDB")) {
+ // then only run NONE and EMPTY_PROPS, cause we are
rolling EMPTY_PROPS first
+ if (gcType != FullGCMode.NONE && gcType !=
FullGCMode.EMPTYPROPS
+ && gcType != FullGCMode.GAP_ORPHANS_EMPTYPROPS) {
+ // temporarily skip due to slowness
+ continue;
+ }
+ }
Review Comment:
This is not necessary. I will revert the changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
