thomasmueller commented on code in PR #1813:
URL: https://github.com/apache/jackrabbit-oak/pull/1813#discussion_r1808738579
##########
oak-query-spi/src/main/java/org/apache/jackrabbit/oak/spi/query/QueryLimits.java:
##########
@@ -39,12 +39,22 @@ default boolean getImprovedIsNullCost() {
return true;
}
+ /**
+ * See OAK-11214. This method is used for backward compatibility
+ * (bug compatibility) only.
+ *
+ * @return true, except when backward compatibility for OAK-11214 is
enabled
+ */
+ default public boolean getOptimizeFunctionInList() {
Review Comment:
I also don't like the function name :-) Just a few points:
* FYI this method isn't supposed to be called anywhere except for the
current code. And I hope we can remove the toggle in about a year or so.
* All the current getters have the "get" prefix (including boolean) so I
think "get" is best.
* I wanted to use "getOptimize" first because I think we will soon have more
of those "getOptimizeXYZ". So these methods have a similar prefix.
* I think no matter what the name is, it can not _really_ convey what this
is about... one basically _has_ to read the Jira issue to understand the
problem.
Said that, what about the following alternative:
`getOptimizeInRestrictionsForFunctions()` ? It is longer, but is it better?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
