rishabhdaim commented on code in PR #1824:
URL: https://github.com/apache/jackrabbit-oak/pull/1824#discussion_r1820535675
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoVersionGCSupport.java:
##########
@@ -253,9 +253,9 @@ public Iterable<NodeDocument> getModifiedDocs(final long
fromModified, final lon
// (_modified = fromModified && _id > fromId || _modified >
fromModified && _modified < toModified)
final Bson query = or(
withIncludeExcludes(includedPathPrefixes, excludedPathPrefixes,
- and(eq(MODIFIED_IN_SECS,
getModifiedInSecs(fromModified)), gt(ID, fromId))),
+ and(eq(MODIFIED_IN_SECS,
TimeUnit.MILLISECONDS.toSeconds(fromModified)), gt(ID, fromId))),
Review Comment:
I don't think this is a correct fix. In the `document store`, we round off
`_modified` to the nearest 5 sec value.
@stefan-egli wdyt?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
