anchela commented on code in PR #1811: URL: https://github.com/apache/jackrabbit-oak/pull/1811#discussion_r1821306962
########## oak-security-spi/src/main/java/org/apache/jackrabbit/oak/spi/security/principal/PrincipalMembershipReaderFactory.java: ########## Review Comment: also the interface in security-spi should not be needed for adding/changing benchmarks. is suspect that's just a left-over from some other refactoring. no? ########## oak-core/src/main/java/org/apache/jackrabbit/oak/security/user/PrincipalMembershipReaderImpl.java: ########## Review Comment: this class should not be part of the benchmark PR, should it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
