reschke commented on code in PR #1836:
URL: https://github.com/apache/jackrabbit-oak/pull/1836#discussion_r1824279221


##########
oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/basic/DefaultSyncContextTest.java:
##########
@@ -1459,7 +1459,7 @@ public void testCreateValuesEmptyCollection() throws 
Exception {
 
     @Test
     public void testCreateValuesSkipsNull() throws Exception {
-        List<String> strings = Lists.newArrayList("s", null, null, "t");
+        List<String> strings = new ArrayList<>(Arrays.asList("s", null, null, 
"t"));

Review Comment:
   Because "List.of" does not suppoet null. See 
https://issues.apache.org/jira/browse/OAK-11239



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to