rishabhdaim commented on code in PR #1779:
URL: https://github.com/apache/jackrabbit-oak/pull/1779#discussion_r1828870465


##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreService.java:
##########
@@ -671,6 +680,10 @@ protected void deactivate() {
             docStoreEmbeddedVerificationFeature.close();
         }
 
+        if (prevNoPropCacheFeature != null) {

Review Comment:
   Though this is unrelated to this PR, could you please add a utility method 
that accepts an array of `Feature` and closes them all?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to