nfsantos commented on code in PR #1878:
URL: https://github.com/apache/jackrabbit-oak/pull/1878#discussion_r1858828301
##########
oak-store-spi/src/main/java/org/apache/jackrabbit/oak/spi/filter/PathFilter.java:
##########
@@ -195,4 +197,12 @@ public boolean areAllDescendantsIncluded(String path) {
}
return false;
}
+
+ private static void checkPathsAreAbsolute(Iterable<String> paths, String
pathType) {
+ for (String path : paths) {
+ if (!PathUtils.isAbsolute(path)) {
+ throw new IllegalStateException("Invalid path in " + pathType
+ " paths list: " + path + ". Paths must be absolute.");
Review Comment:
I agree it would be better, but the PathFilter constructor is already
throwing `IllegalStateException` in a check it does in the constructor, so I
prefer to keep it consistent and use the same exception.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
