reschke commented on code in PR #2224:
URL: https://github.com/apache/jackrabbit-oak/pull/2224#discussion_r2039158040
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentNodeStoreBuilder.java:
##########
@@ -534,13 +533,13 @@ public DiffCache getDiffCache(int clusterId) {
* @return this
*/
public T setBlobStore(BlobStore blobStore) {
- this.blobStoreSupplier = ofInstance(blobStore);
+ this.blobStoreSupplier = () -> blobStore;
return thisBuilder();
}
public BlobStore getBlobStore() {
if (blobStoreSupplier == null) {
- blobStoreSupplier = ofInstance(new MemoryBlobStore());
+ blobStoreSupplier = () -> new MemoryBlobStore();
Review Comment:
yes, that code is similar but it does not appear to have test coverage...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
