nit0906 commented on code in PR #2234:
URL: https://github.com/apache/jackrabbit-oak/pull/2234#discussion_r2055260208
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticIndexHelper.java:
##########
@@ -97,9 +104,47 @@ private static ObjectBuilder<TypeMapping>
loadMappings(@NotNull TypeMapping.Buil
if (indexDefinition.inferenceDefinition != null) {
mapInferenceDefinition(builder,
indexDefinition.inferenceDefinition);
}
+ if (InferenceConfig.getInstance().isEnabled()) {
+ mapInferenceConfig(builder, indexDefinition,
InferenceConfig.getInstance());
+ }
return builder;
}
+ private static void mapInferenceConfig(TypeMapping.Builder builder,
@NotNull ElasticIndexDefinition indexDefinition, @NotNull InferenceConfig
inferenceConfig) {
+ String indexName = PathUtils.getName(indexDefinition.getIndexName());
+ InferenceIndexConfig inferenceIndexConfig;
+// try {
+ // Store the inference configuration in the index metadata so that it
can be used by the inference service
Review Comment:
inference service ? Do you mean enrichment service ? Also, without context,
of what an inference or an enrichment service is - the comment can be confusing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
