joerghoh commented on code in PR #1152:
URL: https://github.com/apache/jackrabbit-oak/pull/1152#discussion_r2068568435


##########
oak-core/src/test/java/org/apache/jackrabbit/oak/security/user/UserImporterMembershipIgnoreTest.java:
##########
@@ -65,7 +65,7 @@ public void before() throws Exception {
         assertTrue(importer.start(memberRefList));
     }
 
-    @Test(expected = IllegalArgumentException.class)

Review Comment:
   I think that the best way would be to subclass the the 
InvalidArgumentException and throw this specialized exception in this case; and 
in some codepaths we can catch this specialized exception and handle it 
differently, while to fallback to the existing handling IAE handling for the 
others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to