kwin commented on code in PR #2258:
URL: https://github.com/apache/jackrabbit-oak/pull/2258#discussion_r2073654049
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/ReadWriteNamespaceRegistry.java:
##########
@@ -71,11 +71,13 @@ public void registerNamespace(String prefix, String uri)
// sanity check for legal namespace names (excluding the "internal"
// namespace, see OAK-74)
- if (!NamespaceConstants.NAMESPACE_REP.equals(uri)) {
- if (!uri.contains(":")) {
+ if (!NamespaceConstants.NAMESPACE_REP.equals(uri) &&
!uri.contains(":")) {
+ if
(Boolean.parseBoolean(System.getProperty("oak.allowInvalidNamespaceUris",
"true"))) {
Review Comment:
Done in
https://github.com/apache/jackrabbit-oak/pull/2258/commits/e90fc3bf65d965728c8f7a74183ab8098ffe8acb
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/name/ReadWriteNamespaceRegistry.java:
##########
@@ -71,11 +72,15 @@ public void registerNamespace(String prefix, String uri)
// sanity check for legal namespace names (excluding the "internal"
// namespace, see OAK-74)
- if (!NamespaceConstants.NAMESPACE_REP.equals(uri)) {
- if (!uri.contains(":")) {
+ if (!NamespaceConstants.NAMESPACE_REP.equals(uri) &&
!uri.contains(":")) {
+ final boolean allowInvalidNamespaceUris =
SystemPropertySupplier.create("oak.allowInvalidNamespaceUris", false)
Review Comment:
Done in
https://github.com/apache/jackrabbit-oak/pull/2258/commits/e90fc3bf65d965728c8f7a74183ab8098ffe8acb.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
