fabriziofortino commented on code in PR #2346:
URL: https://github.com/apache/jackrabbit-oak/pull/2346#discussion_r2163539763
##########
oak-search-elastic/src/main/java/org/apache/jackrabbit/oak/plugins/index/elastic/index/ElasticDocument.java:
##########
@@ -79,6 +81,7 @@ public class ElasticDocument {
this.fulltext = new LinkedHashSet<>();
this.suggest = new LinkedHashSet<>();
this.spellcheck = new LinkedHashSet<>();
+ this.nullProperties = new LinkedHashSet<>();
this.properties = new HashMap<>();
Review Comment:
the properties using `LinkedHashSet` are multi-valued stored in a single ES
field. Using `HashSet` will not preserve the order. This can slightly affect
relevance but mostly will make it harder to debug (when looking at the document
source).
`properties` is an `HashMap` because it gets _extracted_ into multiple
fields, so the order there is not important.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
