mreutegg commented on code in PR #2393:
URL: https://github.com/apache/jackrabbit-oak/pull/2393#discussion_r2236748735
##########
oak-segment-aws/src/main/java/org/apache/jackrabbit/oak/segment/aws/tool/AwsSegmentStoreMigrator.java:
##########
@@ -200,18 +201,13 @@ private void migrateSegments(SegmentArchiveReader reader,
SegmentArchiveWriter w
private void migrateBinaryRef(SegmentArchiveReader reader,
SegmentArchiveWriter writer) throws IOException {
Buffer binaryReferences = reader.getBinaryReferences();
- if (binaryReferences != null) {
- byte[] array = fetchByteArray(binaryReferences);
- writer.writeBinaryReferences(array);
- }
+ byte[] array = fetchByteArray(binaryReferences);
+ writer.writeBinaryReferences(array);
Review Comment:
I don't feel comfortable changing migration semantics and would rather like
to focus on usages when reading a segment graph. That is, ensure a graph is
computed when needed and absent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
