joerghoh commented on code in PR #2415:
URL: https://github.com/apache/jackrabbit-oak/pull/2415#discussion_r2243064839
##########
oak-jcr/src/main/java/org/apache/jackrabbit/oak/jcr/session/NodeImpl.java:
##########
@@ -1342,8 +1344,11 @@ protected Tree createValue() {
}
private boolean canReadMixinTypes(@NotNull Tree tree) {
- return sessionContext.getAccessManager().hasPermissions(
- tree, EMPTY_MIXIN_TYPES, Permissions.READ_PROPERTY);
+ // cache this information per SessionContext, as it is valid
independent of the node
Review Comment:
hmpf, for some reason I oversaw this ``tree`` parameter.
But on a different view, does it even make sense to disallow reading the
mixin types in the context of ``Node.isNodeType()``? In that case this API call
could return a different result, depending if I have read access to that
property or not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
