Joscorbe commented on code in PR #2426:
URL: https://github.com/apache/jackrabbit-oak/pull/2426#discussion_r2253524075
##########
oak-store-document/src/main/java/org/apache/jackrabbit/oak/plugins/document/mongo/MongoDocumentNodeStoreBuilderBase.java:
##########
@@ -44,12 +48,25 @@ public abstract class MongoDocumentNodeStoreBuilderBase<T
extends MongoDocumentN
private MongoStatus mongoStatus;
private long maxReplicationLagMillis = TimeUnit.HOURS.toMillis(6);
private boolean clientSessionDisabled = false;
- private int leaseSocketTimeout = 0;
+ private Integer leaseSocketTimeout;
private String uri;
private String name;
private String collectionCompressionType;
private MongoClient mongoClient;
+ // MongoDB connection pool settings
+ private Integer maxPoolSize;
Review Comment:
They are Integers because in case they are not set (null), they won't be
applied and the driver will take the defaults.
Can change them if this is a strong opinion, but my plan was to leave it to
the driver's default if we don't set anything (which only happens in no-OSGi
runtime).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
