jelmini commented on PR #2453: URL: https://github.com/apache/jackrabbit-oak/pull/2453#issuecomment-3196687634
I wonder if parallelizing `AzureArchiveManager#delete` is safe, in case Oak crashes while deleting the archive. Currently `AzureArchiveManager#listArchives` considers an archive to be deleted if no blob starting with `0000.` is present. By parallelizing, the segment starting with `0000.` may be deleted after other blobs (other segments or the `closed` blob). In case of crash, the `0000.` may still be there: `TarReader`will then attempt to open the archive and fail, preventing the repository to initialize. However, I'm not even sure the current sequential code is safe either, as the order of the blobs returned by `AzureUtilities#getBlobs` is not specified. In any case, I suggest to validate the behavior in case of crash before introducing this change in `AzureArchiveManager#delete`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: oak-dev-unsubscr...@jackrabbit.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
